fix: derive SamlConfig from SAMLOptions #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
approved these changes
Dec 15, 2020
|
@gugu Since you were involved in a lot of the TypeScript conversions, I'd like you to have a look at this too. It seems good to me, but 4 eyes can't hurt :) |
|
Looks good |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strategy and MultiSamlStrategy accept an "options" parameter with three fields which are used locally by the strategy, and remaining fields which are passed on to the SAML constructor.
There was an issue where certain fields (e.g.
privateKey) could not be passed to the Strategy constructor but had to be passed on to the SAML constructor. This fixes that more thoroughly than #497, also fixing the type ofauthnContext, the limited string parameters, and addingxmlSignatureTransforms,digestAlgorithmanddisableRequestACSUrl.Checklist: