Ignore test folder when building npm package
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #525 |
cjbarth
requested changes
Jan 29, 2021
cjbarth
approved these changes
Jan 29, 2021
cjbarth
changed the title
test folder when building npm package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for taking the time to create a PR to support this community-maintained project. We are all volunteers here, so features are only added by contributers like you. Please also be patient while the maintainers work to review your proposed changes for quality and effacy.
Please include a summary of the change and, where appropriate, which issue is addressed.
Your description should also include a comment about the use-case for this change, including what systems you may be interfacing with that require this change. This will help future users know how this library is being used in the wild and how well supported it is.
If the change involves the SAML specification, please include a link to the relavent part(s) of the SAML specificaiton. Doing so speeds up the review process and helps the maintainers make sure that this project remains spec-compliant. You might start here to find the part of the specificaiton that relates to this PR.
Please include tests. Doing so will ensure that the changes made in this PR are not undone or otherwise corrupted by future changes.
Checklist: