Add support for multiple signing certs in metadata #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
previously approved these changes
Oct 19, 2021
|
It appears that node-saml/node-saml#23 has merged. @barryhagan , can you finish up this PR so we can land it? |
barryhagan
force-pushed
the
signing-cert-rotation
branch
from
640afaa
to
97a233c
Compare
Yep, rebased and pushed |
cjbarth
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to pass an array of signing certs when generating SAML metadata. This makes it possible to do signing certificate rotation with IdPs that poll for metadata updates.
See the PR in node-saml for more details.
Checklist: