Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup in preparation for logout validation #658

Merged
merged 2 commits into from Nov 29, 2021

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Nov 18, 2021

This is some code clean-up to prepare for a follow-on PR to enable logout validation. This cleans up the README, adds some more types, and removes some linter warnings.

@cjbarth cjbarth added chore Refactoring, etc. to keep code-rot in check. dependencies Pull requests that update a dependency file documentation Request for or contribution to documentation labels Nov 18, 2021
@cjbarth cjbarth requested a review from a team November 23, 2021 14:44
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markstos markstos merged commit 8522a15 into node-saml:master Nov 29, 2021
@cjbarth cjbarth deleted the validate-logout-prep branch November 29, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, etc. to keep code-rot in check. dependencies Pull requests that update a dependency file documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants