Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TypeScript-required types to dependencies from devDependencies #686

Merged
merged 1 commit into from Apr 4, 2022
Merged

Move TypeScript-required types to dependencies from devDependencies #686

merged 1 commit into from Apr 4, 2022

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Apr 4, 2022

Description

Update use of types to match the recommendations of TypeScript.

Checklist:

@cjbarth cjbarth linked an issue Apr 4, 2022 that may be closed by this pull request
[BUG] 3.0.0 typescript compiler: Could not find a declaration file for module 'passport-strategy' #606
Closed
@markstos
Copy link
Contributor

markstos commented Apr 4, 2022

At my company we also mostly gave up on using devDependencies and just use dependencies, so I'm not surprised this same kind of problem came up in the complex TypeScript ecosystem as well.

markstos
markstos approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed diff.

@markstos markstos merged commit 21319c5 into node-saml:master Apr 4, 2022
@cjbarth cjbarth deleted the strategy-types branch April 6, 2022 02:10
@cjbarth cjbarth added the dependencies Pull requests that update a dependency file label Jun 25, 2022
@srd90 srd90 mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstos markstos markstos approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 3.0.0 typescript compiler: Could not find a declaration file for module 'passport-strategy'
2 participants
@cjbarth @markstos