Use logoutUrl for generateLogoutRequest #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Url instead of options.entryPoint, allowing LogoutRequests to validate properly
|
Any chance this sees the light of day? |
|
Sorry, been a little busy and haven't had a chance to review, but yes, I'm open to merging. Will try to take a closer look soon. |
|
Looks good, thanks for the PR! |
ploer
added a commit
that referenced
this pull request
Jan 23, 2015
Use logoutUrl for generateLogoutRequest
|
Pushed to npm as 0.8.0. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when generating a LogoutRequest,
options.entryPointis used as the@Destinationproperty. This will not validate from an IdP, resulting in the user not logging out. Setting@Destinationtooptions.logoutUrlfixes this issue, allowing the user to log out of the IdP and be correctly redirected back.