Add parameter @ForceAuthn to SAML AuthnRequest. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by forceAuthn option: true/false (default false)
|
👍 This is a feature we require for our project using passport-saml, I hope this will be accepted |
|
Thanks for the PR, we can definitely add this. I think I'd prefer if it only emited the ForceAuthn field if true, though. (in the interests of just not changing existing behaviors if not neccessary). Can you update the PR with that change? Could you also include a proposed change to the readme to document the new option? |
…thn description in README.md
|
Yep, I updated it. |
ploer
added a commit
that referenced
this pull request
Feb 5, 2015
Add parameter @ForceAuthn to SAML AuthnRequest.
|
Merged & published as 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Is it possible to add @ForceAuthn to SAML AuthnRequest? It is configurable by forceAuthn boolean option (default false)