Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async response for built in algo sign/verify #209

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

troyfactor4
Copy link
Contributor

Easier async integration in other projects when using built in sign/verify algorithms

@troyfactor4
Copy link
Contributor Author

Apologies for the many PR's. This should be the last one.

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit 79fc2ac into node-saml:master Apr 14, 2020
@LoneRifle
Copy link
Collaborator

LoneRifle commented Apr 17, 2020

@troyfactor4 - given that this library is passively maintained, I thought you might want to know that there are a couple of other libraries that provides XML Digital Signatures:
xmldsigjs - support for XMLDSIG
xadesjs - support for XAdES and XMLDSIG built on top of xmldsigjs

The READMEs seem to indicate that the libraries are not production-ready, but they are already in development ofr 3 years and have v2.x releases, so perhaps it might be good to discuss whether you should use their libraries instead with @microshine

@cjbarth
Copy link
Contributor

cjbarth commented Jul 21, 2023

@LoneRifle is this an official recommendation? That is to say, is this library no longer adding value to the NPM ecosystem?

@LoneRifle
Copy link
Collaborator

That's from long ago, before you came along and did active management again!

@cjbarth
Copy link
Contributor

cjbarth commented Jul 21, 2023

I understand that. I'm just wondering if other libraries do what this library does, then let's work together and avoid duplicate effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants