Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #201 #218

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix for #201 #218

merged 1 commit into from
Mar 15, 2021

Conversation

paulish
Copy link
Contributor

@paulish paulish commented Oct 19, 2020 •
edited by LoneRifle

  • use existingPrefixes while lookup for references
  • appropriate test

Fixes #201

@paulish paulish mentioned this pull request Oct 19, 2020
Closed
LoneRifle
LoneRifle approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit 52aa883 into node-saml:master Mar 15, 2021
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
@cjbarth cjbarth added the bug label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to sign nodes with namespace prefix
3 participants
@paulish @LoneRifle @cjbarth