Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #124

Merged
merged 1 commit into from
Mar 20, 2015
Merged

Update dependencies #124

merged 1 commit into from
Mar 20, 2015

Conversation

jonhester
Copy link
Contributor

Updates long-timeout to current version. I also sinon to the current version and prefix all the devDependencies with ^. I think we should keep the dependencies locked to avoid potential issues in new patch or minor releases that we haven't tested with.

@santigimeno
Copy link
Member

LGTM

tejasmanohar added a commit that referenced this pull request Mar 20, 2015
@tejasmanohar tejasmanohar merged commit be43e1b into node-schedule:master Mar 20, 2015
@tejasmanohar
Copy link
Member

You can use branches on node-schedule rather than forks to PR now that you're a collaborator, too. btw

@jonhester
Copy link
Contributor Author

@tejasmanohar Cool, what would your preference be one branch per feature/fix. Or stay with pull requests? I'm fine with whatever you prefer.

@jonhester
Copy link
Contributor Author

@tejasmanohar The only thing that may be better about pull requests is that they are easier to merge based on tests/linting passing since that won't work the same way with commits to other branches.

@jonhester jonhester deleted the update-dep branch March 20, 2015 18:01
@tejasmanohar
Copy link
Member

Oh, I meant you can send PRs from branches on node-schedule/node-schedule rather than a fork.

@tejasmanohar
Copy link
Member

In general, PRs are best except for small changes / fixes that are really indisputable. For ongoing work, use a non-master branch, for sure.

@jonhester
Copy link
Contributor Author

Ahh, that makes way more sense. I've just recently started contributing so I'm new to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants