-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generators #210
Conversation
👍 overall... This is fair. It won't hurt usage in older versions of node but the tests will fail on older v of node. Maybe we should skip the generator tests on old versions of node (based on PS: could be a better way to do it, this is just my first thought |
@tejasmanohar yeah I just committed that. I forgot that JS does not approve of syntax errors. This was meant to pass tests in 0.12 and 0.10, I simply derped. Waiting for that green light. 😄 |
It's passing on everything now! |
hahahaha, i feel you :P |
100% fine in my eyes. useful addition for those using the feature in es6/7 + no interference :) |
Add support for generators
💯 whoop |
Cheers! 👍 |
This patch adds support for ES6 generators, without introducing any issues for older versions of node that don't support them.
It allows the use case like the following: