Fix generator detection edge case #213
Conversation
|
I'll be investigating whether using |
|
Ah, don't merge this yet, going to make a minor change. |
|
@bbqsrc Please don't change the I should do this through a manual merge most likely and increment the version. |
|
Fair enough. Will rebase it out. |
|
Thx, can merge the two commits into one too since it's a single fix :) |
|
It's passing now. I don't know why the pull request has added your commit though. 😕 |
|
Lol huh, did you merge something downstream or mess up cherry-pick/rebase? @bbqsrc |
If you do something odd like function*(){}.bind(this), the
use of .bind causes the resultant function to not have a
prototype property *at all*. ಠ_ಠ
|
There we go. I had done Excuse me while I go wallow in shame over here. |
|
haha |
|
but yeah this makes sense to me. nice catch |
Fix generator detection edge case
If you do something odd like
function*(){}.bind(this), the use of.bindcauses the resultant function to not have aprototypeproperty at all. ಠ_ಠNote I've already incremented the patch version in the
package.json.