Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draws more attention to recurrence rule default values. #248

Merged
merged 1 commit into from Feb 4, 2016
Merged

Draws more attention to recurrence rule default values. #248

merged 1 commit into from Feb 4, 2016

Conversation

martellaj
Copy link
Contributor

This is a very minor patch to the README, spurred from my own experience with missing the affected line when making a recurrence rule. My update just draws more attention to that last bit where you explain that if you don't explicitly set the minute value to 0, the job will be executed every minute of the hour.

@martellaj
Copy link
Contributor Author

Looks like y'all have merged some bad code into here. I only touched the README and your CI build broke.

@santigimeno
Copy link
Member

The tests are fine. It's just the test coverage step failing. Not a big deal. Thanks for the contribution

@santigimeno santigimeno merged commit eecd6bf into node-schedule:master Feb 4, 2016
@santigimeno
Copy link
Member

@tejasmanohar The issue with Travis seems related with the Coveralls configuration. I've no experience with it, could you check it? Thanks! Link: https://travis-ci.org/node-schedule/node-schedule/builds/107028308

@tejasmanohar
Copy link
Member

Hm, coverrals won't show node-schedule/node-schedule in the available sources for me to set for the project. I will look more into it this evening & contact support if necessary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants