fix: electron 11 prebuilds broken #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
changed the title
|
@reconbot any chance of this getting merged? It will make building for electron 11 much easier |
|
lets do it, sorry I missed this ALSO I wish they'd fix this upstream |
|
@reconbot Could you trigger a new build of the bindings? Otherwise they cant be resolved. Thank you :) |
|
https://github.com/serialport/node-serialport/actions/runs/878496051 that should have happened automatically - I'm hoping something didn't change in lerna... |
|
thank you! :) |
lvogt
pushed a commit
to lvogt/node-serialport
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2191
A temporary fix until fixed upstream electron/node-abi#103 or prebuild/prebuild#275
As explained in my comment #2191 (comment), electron v11.0.0-beta.12 started to define the variable
V8_REVERSE_JSARGS. But as prebuild/node-abi use v11.0.0-beta.11 for producing the prebuilds, this resulted in binaries which were broken.This is the simplest way I could find to do this while keeping it scoped to just electron 11. I couldn't find a way to check
NODE_MODULE_VERSIONin binding.gyp, so I had to do it in serialport.h instead.It is limited to windows as that appears to be the only platform that is broken, and without testing I don't know what the impact would be on other platforms