fix: electron 11 prebuilds were broken (#2237)

serialport · May 24, 2021 · ac25b3a · ac25b3a
1 parent 5beaf47
commit ac25b3a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/bindings/binding.gyp b/packages/bindings/binding.gyp
@@ -10,6 +10,7 @@
     'conditions': [
       ['OS=="win"',
         {
+          'defines': ['CHECK_NODE_MODULE_VERSION'],
           'sources': [
             'src/serialport_win.cpp'
           ],

diff --git a/packages/bindings/src/serialport.h b/packages/bindings/src/serialport.h
@@ -1,5 +1,12 @@
 #ifndef PACKAGES_SERIALPORT_SRC_SERIALPORT_H_
 #define PACKAGES_SERIALPORT_SRC_SERIALPORT_H_
+
+// Workaround for electron 11 abi issue https://github.com/serialport/node-serialport/issues/2191
+#include <node_version.h>
+#if CHECK_NODE_MODULE_VERSION && NODE_MODULE_VERSION == 85
+#define V8_REVERSE_JSARGS
+#endif
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>