Disconnect is poorly defined and doesn't always work

[reconbot]

We call disconnected from all over the place, c++ bindings call it from the options. Occasionally we remove all events. Sometimes we emit the close event. It's also not documented.

Having this be the discussion issue around how it currently works and how we should fix it up.

[fivdi]

@reconbot should the issue title be "Disconnect is poorly defined and doesn't always work"?

[reconbot]

yep =)

[reconbot]

We now have a single disconnect path and never remove events. I think ... I think this is closable.

While there are internal cleanups to be had, the api is now documented and consistent.