Fix invalid chars caused JSON parse failed (#64)

lib/api_common.js

@@ -3,6 +3,9 @@
 // 本文件用于wechat API，基础文件，主要用于Token的处理和mixin机制
 const httpx = require('httpx');
 const liburl = require('url');
+const {
+  replaceJSONCtlChars
+} = require('./util');
 
 class AccessToken {
   constructor(accessToken, expireTime) {
@@ -123,7 +126,7 @@ class API {
     if (contentType.indexOf('application/json') !== -1) {
       var data;
       try {
-        data = JSON.parse(buffer);
+        data = JSON.parse(replaceJSONCtlChars(buffer.toString()));
       } catch (ex) {
         let err = new Error('JSON.parse error. buffer is ' + buffer.toString());
         err.name = 'WeChatAPIError';

lib/util.js

@@ -13,3 +13,23 @@ exports.postJSON = function (data) {
     }
   };
 };
+
+
+const JSONCtlCharsMap = {
+  '"': '\\"',       // \u0022
+  '\\': '\\\\',     // \u005c
+  '\b': '\\b',      // \u0008
+  '\f': '\\f',      // \u000c
+  '\n': '\\n',      // \u000a
+  '\r': '\\r',      // \u000d
+  '\t': '\\t'       // \u0009
+};
+const JSONCtlCharsRE = /[\u0000-\u001F\u005C]/g;
+
+function _replaceOneChar(c) {
+  return JSONCtlCharsMap[c] || '\\u' + (c.charCodeAt(0) + 0x10000).toString(16).substr(1);
+}
+
+exports.replaceJSONCtlChars = function (str) {
+  return str.replace(JSONCtlCharsRE, _replaceOneChar);
+};

package.json

@@ -4,7 +4,8 @@
   "description": "微信公共平台Node库API，ES6版本",
   "main": "index.js",
   "scripts": {
-    "test": "make test-all"
+    "test": "make test-all",
+    "test-file": "mocha -R spec"
   },
   "repository": {
     "type": "git",
@@ -19,11 +20,10 @@
     "httpx": "^2.1.1"
   },
   "devDependencies": {
-    "co-mocha": "*",
     "coveralls": "*",
     "eslint": "*",
     "expect.js": "*",
-    "mocha": "*",
+    "mocha": "^4.0.1",
     "muk": "*",
     "nyc": "^10.2.0",
     "rewire": "*",

test/api_common.test.js

@@ -58,4 +58,5 @@ describe('api_common', function () {
       }
     });
   });
+
 });

test/fixture/invalid.json

@@ -0,0 +1 @@
+{"subscribe":1,"openid":"ogW8rt6i8BmyHaXvleP5SBULysSk","nickname":"Íõ¾ü","sex":1,"language":"zh_CN","city":"y?v\","province":"l?S","country":"","headimgurl":"http://wx.qlogo.cn/mmopen/Q3auHgzwzM4nXzLJEGv1SUt5ibMeibUjmaK45y06UOtaKDc2NgjvjjnsiccgwMPyKOwvstIKA85bM7zziac5m9zmfw/0","subscribe_time":1504246660,"unionid":"oKfK5s5qiqgWMHaeJ6f3sy5TYvx8","remark":"","groupid":0,"tagid_list":[]}

test/util.test.js

@@ -0,0 +1,23 @@
+'use strict';
+
+const path = require('path');
+const fs = require('fs');
+
+const expect = require('expect.js');
+
+const util = require('../lib/util');
+
+const filepath = path.join(__dirname, 'fixture/invalid.json');
+const str = fs.readFileSync(filepath, 'utf8').trim();
+
+describe('util', function () {
+  it('json parse with invalid chars', function () {
+    expect(() => {
+      JSON.parse(str);
+    }).to.throwException(/Unexpected token/);
+
+    expect(() => {
+      JSON.parse(util.replaceJSONCtlChars(str));
+    }).not.to.throwException();
+  });
+});