Mini-Program support. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonTian
requested changes
Apr 23, 2018
lib/oauth.js
Outdated
| var user = decrypter.decryptData(options.encryptedData, options.iv); | ||
| return callback(null, user); | ||
| }catch (e) { | ||
| return callback(new Error('error occurred when trying to decrypt mini-program user data')); |
There was a problem hiding this comment.
try {
callback();
} catch(ex) {
callback();
}是一种不好的范式。当 callback 中出错时， callback 会被调用2次。
|
There is a change need to be done, see comments. Thanks for you contribution. |
|
Could you please port the implement to co-wechat-oauth ? |
|
I have released the feature to NPM. 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported Wechat-Mini-Program OAuth, or OAuth like mechanism, since we just need a small part of the whole OAuth protocol to support mini-program, which simplified the auth procedure for server.
The only thing need to be done when trying to use mini-program OAuth is to pass a
isMiniProgramparam as the fifth param in the constructor.Simple unit tests and doc changes are also included in this PR.
Plz tell me if any further work need to be done.