Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gclient_config is not part of depot_tools #34

Closed
burg opened this issue Dec 6, 2013 · 6 comments · Fixed by #62
Closed

gclient_config is not part of depot_tools #34

burg opened this issue Dec 6, 2013 · 6 comments · Fixed by #62

Comments

@burg
Copy link

burg commented Dec 6, 2013

I think you need to use gclient config <stuff> as gclient_config is not distributed with a new depot_tools checkout.

[burg@burg183 node-webrtc]# npm install

> wrtc@0.0.6 install /Users/burg/repos/node-webrtc
> node build.js

gclient_config
.
gclient_config failed: 127 null

@modeswitch
Copy link

Do you have depot_tools installed an in your path? What happens when you run gclient in your terminal?

@burg
Copy link
Author

burg commented Dec 7, 2013

Yes, I do. gclient is a valid executable but gclient_config is not.

On Dec 6, 2013, at 5:55 PM, Alan K notifications@github.com wrote:

Do you have depot_tools installed an in your path? What happens when you run gclient in your terminal?


Reply to this email directly or view it on GitHub.

@modeswitch
Copy link

Npm is calling build.js, which runs

function gclient_config(callback)
{
  console.info("gclient_config");
  process.stdout.write('.');
  process.chdir(LIB_WEBRTC_DIR);
  child = exec("gclient config http://webrtc.googlecode.com/svn/trunk");
  child.on('exit', function(code, signal)
  {
    process.stdout.write('\n');
    if(0 === code && !signal)
    {
      console.log('gclient_config complete');
      gclient_sync(callback);
    }
    else
    {
      console.error('gclient_config failed:', code, signal);
    }
  });
}

It's calling gclient config http://webrtc.googlecode.com/svn/trunk. Can you try checking out the code from the github and running the gclient command in the lib/libwebrtc directory?

@modeswitch
Copy link

@burg Also, which platform are you on?

@modeswitch
Copy link

I'm not able to reproduce this. Please re-open and provide additional details if you're still having this problem.

@thanpolas
Copy link
Contributor

@modeswitch i experience the same issue, i also just read #58 which may be related.

I'm on osx 10.9.1 (latest), depot tools last SHA is d03893e 2014-01-30 and is in path.

npm install will produce the same exact error as @burg reported. When i run the command your script suggests:

gclient config http://webrtc.googlecode.com/svn/trunk

It run ok, nothing happened. I have the repo cloned and mingling... please advise.

thanpolas added a commit to thanpolas/node-webrtc that referenced this issue Jan 31, 2014
modeswitch pushed a commit that referenced this issue Jan 31, 2014
wrong path in conditional for build script. fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants