Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SCTP data channels #5

Closed
modeswitch opened this issue Oct 15, 2013 · 22 comments
Closed

Support SCTP data channels #5

modeswitch opened this issue Oct 15, 2013 · 22 comments

Comments

@modeswitch
Copy link

Blocked by https://code.google.com/p/webrtc/issues/detail?id=2279.

@piranna
Copy link
Contributor

piranna commented Oct 15, 2013

This means there's currently DataChannel support or not?
El 15/10/2013 20:45, "Alan K" notifications@github.com escribió:

Blocked by https://code.google.com/p/webrtc/issues/detail?id=2279.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5
.

@modeswitch
Copy link
Author

There's RTP data channel support, but those aren't standard-compliant and won't interoperate with firefox.

@piranna
Copy link
Contributor

piranna commented Oct 15, 2013

Then I think I'll wait until SCTP DataChannels are available, this will
give me some more time to improve my own project :-)
El 15/10/2013 22:37, "Alan K" notifications@github.com escribió:

There's RTP data channel support, but those aren't standard-compliant and
won't interoperate with firefox.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-26370029
.

@fuson
Copy link

fuson commented Oct 16, 2013

Interoperability with chrome is enough for me, cause we use node-webkit for client side. Will it be work?

@piranna
Copy link
Contributor

piranna commented Oct 16, 2013

I don't know, but it should: Chromium is still using RTP DataChannels by
default up to v30.

2013/10/16 Aleksey Mihailiuk notifications@github.com

Interoperability with chrome is enough for me, cause we use node-webkit
for client side. Will it be work?


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-26417554
.

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux

@fuson
Copy link

fuson commented Oct 16, 2013

I hope it will work, cause if google chrome (and node-webkit for sure) will not work with google webrtc... it will be VERY strange :) I'm in waiting for a buildable state of this library :)

@modeswitch
Copy link
Author

It should be buildable now (though I'm getting segfaults after updating libjingle :/). Please let me know if you're having build problems.

@fuson
Copy link

fuson commented Oct 16, 2013

Look at Issue #10 pls about build issue on mac.

@modeswitch
Copy link
Author

Started working on this now. It's non-trivial.

@andrenatal
Copy link

Let me know how can I help.

@modeswitch
Copy link
Author

@andrenatal someone else has taken on the upstream bug while I finish off some other work.

@feross
Copy link

feross commented Dec 2, 2013

@modeswitch excellent news -- glad that the upstream folks see this as a priority.

@kofd
Copy link
Contributor

kofd commented Dec 23, 2013

I noticed in datachannel.js that the implementation of DataChannel._queueOrRun(obj) makes references to this._getPC(). Is this causing errors?

@modeswitch
Copy link
Author

@kofd No. I don't think that code is used anymore for data channels.

@taterbase
Copy link

Forgive my ignorance, it seems the issue has been closed on the jingle project. What is preventing this issue from being closed on this project?

@modeswitch
Copy link
Author

SCTP data channels are still unsupported in libjingle, blocked by this: https://code.google.com/p/webrtc/issues/detail?id=2253

@taterbase
Copy link

Thank you for the clarification!

Sent from my iPhone

On Dec 30, 2013, at 8:32 AM, Alan K notifications@github.com wrote:

SCTP data channels are still unsupported in libjingle, blocked by this: https://code.google.com/p/webrtc/issues/detail?id=2253


Reply to this email directly or view it on GitHub.

@modeswitch
Copy link
Author

A patch was just submitted that enables SCTP data channels. I'll update the code here to use them.

https://code.google.com/p/webrtc/source/detail?r=5459

@piranna
Copy link
Contributor

piranna commented Jan 29, 2014

I see it before, I'm anxious about this (my boss is interested on this
project :-) )

Send from my Samsung Galaxy Note II
El 29/01/2014 20:10, "Alan K" notifications@github.com escribió:

A patch was just submitted that enables SCTP data channels. I'll update
the code here to use them.

https://code.google.com/p/webrtc/source/detail?r=5459

Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-33618669
.

@modeswitch
Copy link
Author

Fixed. Bridge/peer example updated.

@taterbase
Copy link

Really hate to be that guy but this deserves a serious 👍. Thanks for the hard work!

@danzel
Copy link

danzel commented Feb 7, 2014

Thanks @modeswitch :) 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants