Replace node-pre-gyp with supported version #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node-pre-gyp` has been deprecated and renamed `@mapbox/node-pre-gyp` but is otherwise API compatible so this change swaps the deps around. `node-pre-gyp` will no longer receive updates - the `@mapbox` version has already seen a few new releases and should be what's used going forwards. See the release notes: https://github.com/mapbox/node-pre-gyp/blob/HEAD/CHANGELOG.md#100 Fixes node-webrtc#682
|
@markandrus @modeswitch is there anything outstanding you'd like changed on this PR or can it be merged? |
|
@achingbrain @markandrus @modeswitch hey just wondering, when will this get merged/released? |
|
It would certainly be helpful! |
markandrus
approved these changes
Jun 7, 2021
|
@markandrus I'm not sure I understand the ins and outs of wrtc enough to be a maintainer, but I can help out with releases - what's stopping this from being published as a simple patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-pre-gyphas been deprecated and renamed@mapbox/node-pre-gypbut is otherwise API compatible so this change swaps the deps around.node-pre-gypwill no longer receive updates - the@mapboxversion has already seen a few new releases so should be what's used going forwards.See the release notes: https://github.com/mapbox/node-pre-gyp/blob/HEAD/CHANGELOG.md#100
Fixes #682