Make application/octet-stream the default Content-Type #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
commented
Jul 8, 2019
| @@ -247,13 +247,6 @@ function _asyncReadfile (filename) { | |||
| * @return {string} A content type string | |||
| */ | |||
| function getContentType (headers) { | |||
| const headerValue = headers.get ? headers.get('content-type') : headers['content-type'] | |||
|
|
|||
| // Default content type as stated by RFC 822 | |||
There was a problem hiding this comment.
RFC 822 doesn't even contain the string "text/plain" and predates HTTP, so completely bogus.
There was a problem hiding this comment.
Yes. For completeness' sake, RFC 1521 (since obsoleted) would have been the appropriate reference --
When a mail reader encounters mail with an unknown Content-type
value, it should generally treat it as equivalent to
"application/octet-stream", as described later in this document.
TallTed
approved these changes
Jul 8, 2019
RubenVerborgh
force-pushed
the
fix/default-content-type
branch
from
ee34324
to
9674332
Compare
RubenVerborgh
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: