Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete container with file.acl #1410

Merged
merged 1 commit into from
Apr 1, 2020
Merged

delete container with file.acl #1410

merged 1 commit into from
Apr 1, 2020

Conversation

bourgeoa
Copy link
Member

@bourgeoa bourgeoa commented Mar 5, 2020

This allow to delete folder containing orphan file.acl or file.meta
NSS do not do any atomic delete. This should help solve the problem encountered by users not to be able to delete folder where all files have been deleted but not the related file.acl file.meta

@jaxoncreed
Copy link
Contributor

Thanks for the PR, but unfortunately recursive delete is something that's still under discussion (solid/specification#132). I'd be happy to add it if it were decided on in the spec, but for now, all we can do is wait.

@jaxoncreed jaxoncreed closed this Mar 16, 2020
@bourgeoa
Copy link
Member Author

@jaxoncreed
It has nothing to do with recursive. It only authorize folder delete when the folder only contains .acl and does not contain any resource (files) or containers (folders)

@kjetilk
Copy link
Member

kjetilk commented Mar 17, 2020

Right, I think this could be reviewed on its own merits, the problem isn't recursive delete, where there isn't a clear consensus, but the lifecycle of an ACL resource, where the consensus is that:

Deleting a resource must remove associated ACL resource.

So, if it implements this consensus (as it seems to do), I think we're good to merge it.

@jaxoncreed jaxoncreed reopened this Apr 1, 2020
Copy link
Contributor

@jaxoncreed jaxoncreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good then

@jaxoncreed jaxoncreed merged commit 23a92eb into nodeSolidServer:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants