action/append should push new values, not concat
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with 2 positional args, one that takes 1, the other 2, parseArgs with 'a b c' produces spam: ['a','b','c'], but python expects spam: ['a', ['b','c']]. This is because append.js uses 'concat', while python uses 'append'. Correction: change action/append.js set() to use push()
puzrin
pushed a commit
that referenced
this pull request
Jan 4, 2013
action/append should `push` new values, not `concat`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test_argparse.pyTestPositionalsActionAppendhas 2 positional args, one that takes 1 argument, the other 2.parseArgswith'a b c'producesspam: ['a','b','c'], but python expectsspam: ['a', ['b','c']].This is because append.js uses
concat, while python usesappend.Correction: change
action/append.js set()to usepush()