Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #526: wrong quote position writing condensed flow #527

Merged
merged 1 commit into from Nov 15, 2019
Merged

Fix issue #526: wrong quote position writing condensed flow #527

merged 1 commit into from Nov 15, 2019

Conversation

GabrieleC
Copy link
Contributor

@GabrieleC GabrieleC commented Nov 14, 2019

No description provided.

pairBuffer = state.condenseFlow ? '"' : '';

if (index !== 0) pairBuffer += ', ';
pairBuffer = index === 0 ? '' : ', ';
Copy link
Member

@puzrin puzrin Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid such notation, it's not enough easy to read. Use if (index !== 0) pairBuffer += ', '; and so on in appropriate places.

@puzrin
Copy link
Member

puzrin commented Nov 14, 2019

Seems ok in general. Please take a look at comment & squash all to single commit.

@GabrieleC
Copy link
Contributor Author

GabrieleC commented Nov 15, 2019

Seems ok in general. Please take a look at comment & squash all to single commit.

@puzrin Improved readability and squashed commits.

@puzrin puzrin merged commit d6983dd into nodeca:master Nov 15, 2019
1 check passed
@puzrin
Copy link
Member

puzrin commented Nov 15, 2019

Thank you very much!

This was referenced Mar 6, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants