New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify link between pako and zlib #93
Comments
If you ask about this folder https://github.com/nodeca/pako/tree/master/lib/zlib, that's not auto-translated code. We did source as close as possible to original, but JS does not support some features, and there are some differences. Also some features were not implemented. Top level wrappers are not related to zlib and done for convenient use with JS.
I could join zlib license to existing license file. Will it be correct? |
See commit. Does it solve this issue? |
No in this case:
Aknowledgement is fine In order to be safer include zlib license in lib/zlib and add header (comment) about copyright in every files of this folder (§3 of zlib license) Thanks |
Could tell me exact content of header comment? |
https://github.com/nodeca/pako/tree/zlib Moved all into |
See pull request |
Please check eaead04 If it's ok, i'll merge to master and tag new release. |
Feel free to close and make a new release |
Released 1.0.5 Thanks for your help! |
@bastien-roucaries may be you could advice or forward me to someone... Most of my projects have MIT licence. Can i impersonate first line of it? I don't like to type my name as copyright holder there (in case of MIT that gives nothing useful but can add mainenance deals in future). Is it possible to replace copyright holder info with something impersonated but still keep licence legal? |
On Mon, May 15, 2017 at 9:45 AM, Vitaly Puzrin ***@***.***> wrote:
@bastien-roucaries <https://github.com/bastien-roucaries> may be you
could advice or forward me to someone...
Most of my projects have MIT licence. Can i impersonate first line of it?
I don't like to type my name as copyright holder there (in case of MIT that
gives nothing useful but can add mainenance deals in future). Is it
possible to replace copyright holder info with something impersonated but
still keep licence legal?
Yes you can (like node pako team). But you should never remove
a previous author from the list
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEnaHBPGCvyBd0F1EJ3YKIDm4Li8CO6yks5r6AK0gaJpZM4MpKqt>
.
|
"pako team" is better, but still not enougth abstract. Can i use something like "contributors", or "pako contributors"? Here was example with |
Hi,
From debian side for legal reason we want to know the relationship between pako and zlib.
Does you translate zlib ? Do you made a clean room reimplementation ?
Thank you very much
BTW thanking zlib author will be nice in README.md
The text was updated successfully, but these errors were encountered: