Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify link between pako and zlib #93

Closed
bastien-roucaries opened this issue Mar 25, 2017 · 12 comments
Closed

Clarify link between pako and zlib #93

bastien-roucaries opened this issue Mar 25, 2017 · 12 comments

Comments

@bastien-roucaries
Copy link

Hi,

From debian side for legal reason we want to know the relationship between pako and zlib.

Does you translate zlib ? Do you made a clean room reimplementation ?

Thank you very much

BTW thanking zlib author will be nice in README.md

@puzrin
Copy link
Member

puzrin commented Mar 25, 2017

If you ask about this folder https://github.com/nodeca/pako/tree/master/lib/zlib, that's not auto-translated code. We did source as close as possible to original, but JS does not support some features, and there are some differences. Also some features were not implemented.

Top level wrappers are not related to zlib and done for convenient use with JS.

BTW thanking zlib author will be nice in README.md

I could join zlib license to existing license file. Will it be correct?

puzrin pushed a commit that referenced this issue Mar 25, 2017
@puzrin
Copy link
Member

puzrin commented Mar 25, 2017

See commit. Does it solve this issue?

@bastien-roucaries
Copy link
Author

No in this case:

  • lib/zlib is under zlib license with addition from your side under expat (MIT is ambigous).
  • other file are under expat license

Aknowledgement is fine

In order to be safer include zlib license in lib/zlib and add header (comment) about copyright in every files of this folder (§3 of zlib license)

Thanks

@puzrin
Copy link
Member

puzrin commented Mar 26, 2017

Could tell me exact content of header comment?

@puzrin
Copy link
Member

puzrin commented Mar 26, 2017

https://github.com/nodeca/pako/tree/zlib

Moved all into zlib branch to keep master clear until finished. Need help with text to copy into headers. Original headers are for C and refer to zlib.h (not existing in this project). But i'm ready to place there anything you recommend.

@bastien-roucaries
Copy link
Author

See pull request

@puzrin
Copy link
Member

puzrin commented Mar 26, 2017

Please check eaead04

If it's ok, i'll merge to master and tag new release.

@bastien-roucaries
Copy link
Author

Feel free to close and make a new release

@puzrin
Copy link
Member

puzrin commented Mar 26, 2017

Released 1.0.5

Thanks for your help!

@puzrin puzrin closed this as completed Mar 26, 2017
@puzrin
Copy link
Member

puzrin commented May 15, 2017

@bastien-roucaries may be you could advice or forward me to someone...

Most of my projects have MIT licence. Can i impersonate first line of it? I don't like to type my name as copyright holder there (in case of MIT that gives nothing useful but can add mainenance deals in future). Is it possible to replace copyright holder info with something impersonated but still keep licence legal?

@bastien-roucaries
Copy link
Author

bastien-roucaries commented May 15, 2017 via email

@puzrin
Copy link
Member

puzrin commented May 15, 2017

"pako team" is better, but still not enougth abstract. Can i use something like "contributors", or "pako contributors"?

Here was example with Copyright (c) The Chromium AUTHORS, but they still track all in AUTHORS file (i'd like to avoid this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants