Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-eager zone matching #16

Closed
bigdogwillfeed opened this issue Jun 5, 2020 · 3 comments
Closed

Over-eager zone matching #16

bigdogwillfeed opened this issue Jun 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@bigdogwillfeed
Copy link

Thanks for the plugin! I've been able to get it up and running with Greenlock with minimal trouble. However, I did hit a roadblock that I would really appreciate some help with.

We own the domains devresults.com and training-devresults.com, but I'm not able to generate certificates for training-devresults.com because of the logic in how the zone is picked from the list of zones thinks that devresults.com is the zone for e.g., *.training-devresults.com:

if(domain.endsWith(zone.name)){

I made the zone check a bit more strict, and the following works for my in my dev environment (check for exact domain or subdomain match):

if(domain === zone.name || domain.endsWith(`.${zone.name}`)){

Can you help me out?

@Cherry
Copy link
Member

Cherry commented Jun 5, 2020

Thanks for the issue!

This definitely isn't something we thought about during testing, so I appreciate you bringing it to light. Your suggested change looks good - I'll see about testing that and implementing a fix for this soon. 👍

@Cherry Cherry added the bug Something isn't working label Jun 5, 2020
@Cherry Cherry closed this as completed in a59961b Jun 7, 2020
@Cherry
Copy link
Member

Cherry commented Jun 7, 2020

The fix for this landed in version 1.2.3. Thanks for the report once again!

@bigdogwillfeed
Copy link
Author

Works great; thanks for the speedy fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants