fix: over-eager zone matching

Closes #16
nodecraft · Jun 7, 2020 · a59961b · a59961b
1 parent 450850f
commit a59961b
Show file tree

Hide file tree

Showing 4 changed files with 208 additions and 201 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.3] - 2020-06-07
+- Fix over-eager zone matching that could cause certs for `testing-example.com` to fail if domain `example.com` was available
+
 ## [1.2.2] - 2020-05-09
 - Improve Cloudflare error response handling
 

diff --git a/index.js b/index.js
@@ -225,7 +225,7 @@ class Challenge {
 
 	async getZoneForDomain(domain){
 		for await(const zone of consumePages(pagination => this.client.zones.browse(pagination))){
-			if(domain.endsWith(zone.name)){
+			if(domain === zone.name || domain.endsWith(`.${zone.name}`)){
 				return zone;
 			}
 		}