Merge pull request #5 from Rautherdir/update-rules

Add no-else-return and update no-unused-vars and keyword-spacing
nodecraft · Mar 13, 2020 · 0dd9530 · 0dd9530
2 parents bac4c17 + 159f8b0
commit 0dd9530
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/rules/best-practices.js b/rules/best-practices.js
@@ -12,6 +12,9 @@ module.exports = {
 		// require the use of === and !==
 		"eqeqeq": "error",
 
+		// disallow `else` blocks after `return` statements in `if` statements
+		"no-else-return": "error",
+
 		// disallow the use of eval()
 		"no-eval": "error",
 

diff --git a/rules/style.js b/rules/style.js
@@ -104,6 +104,10 @@ module.exports = {
 				"catch": {
 					"before": false,
 					"after": false
+				},
+				"this": {
+					"before": true,
+					"after": false
 				}
 			}
 		}],

diff --git a/rules/variables.js b/rules/variables.js
@@ -3,6 +3,9 @@
 
 module.exports = {
 	rules: {
-
+		// disallow unused variables
+		"no-unused-vars": ["error", {
+			"ignoreRestSiblings": true
+		}]
 	}
 };