Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add argument 'issuance_date' to DIDVCService #237

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rabe1028
Copy link
Contributor

@rabe1028 rabe1028 commented Feb 6, 2024

Description

The date called 'issuance_date' was created in the function of DIDVCService.
To match the time used elsewhere, I changed it to allow passing the time from outside.

@rabe1028 rabe1028 requested a review from a team as a code owner February 6, 2024 15:02
Copy link
Contributor

@da13da da13da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rabe1028 rabe1028 merged commit 9640f85 into main Feb 8, 2024
5 checks passed
@rabe1028 rabe1028 deleted the add-issuance_date-args branch February 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants