🐙 mr anderson vs agent smith no more fuel injection for cat, rec, upload

package.json

@@ -1,6 +1,6 @@
 {
   "name": "extra-asciinema",
-  "version": "1.0.21",
+  "version": "1.0.22",
   "description": "asciinema is a terminal screen recorder.",
   "main": "index.js",
   "module": "index.mjs",

src/_recCmd.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
 
-function recCmd(f: string, o: any=null): string {
+function recCmd(f: string, o: any=null): string[] {
   var o = o||{};
   // if input file given, execute on node.js
   if(o.input) {
@@ -10,18 +10,18 @@ function recCmd(f: string, o: any=null): string {
   }
   o.overwrite = true;
   o.yes = true;
-  var cmd = 'asciinema rec';
-  if(f) cmd += ` "${f}"`;
-  if(o.stdin) cmd += ' --stdin';
-  if(o.append) cmd += ' --append';
-  if(o.raw) cmd += ' --raw';
-  if(o.overwrite) cmd += ' --overwrite';
-  if(o.command) cmd += ` -c "${o.command}"`;
-  if(o.env) cmd += ` -e "${o.env}"`;
-  if(o.title) cmd += ` -t "${o.title}"`;
-  if(o.idleTimeLimit) cmd += ` -e "${o.idleTimeLimit}"`;
-  if(o.yes) cmd += ` -e "${o.yes}"`;
-  if(o.quiet) cmd += ` -e "${o.quiet}"`;
-  return cmd;
+  var args = ['rec'];
+  if(f) args.push(f);
+  if(o.stdin) args.push('--stdin');
+  if(o.append) args.push('--append');
+  if(o.raw) args.push('--raw');
+  if(o.overwrite) args.push('--overwrite');
+  if(o.command) args.push('--command', o.command);
+  if(o.env) args.push('-env', o.env);
+  if(o.title) args.push('--title', o.title);
+  if(o.idleTimeLimit) args.push('--idle-time-limit', ''+o.idleTimeLimit);
+  if(o.yes) args.push('--yes');
+  if(o.quiet) args.push('--quiet');
+  return args;
 }
 export default recCmd;

src/cat.ts

@@ -9,7 +9,7 @@ import type {callbackFn} from './_types';
  */
 function cat(f: string, fn: callbackFn=null): Promise<any> {
   var p = new Promise((fres, frej) => {
-    cp.exec(`asciinema cat ${f}`, {encoding: 'utf8'}, (err, stdout) => {
+    cp.execFile('asciinema', ['cat', f], {encoding: 'utf8'}, (err, stdout) => {
       if(err) return frej(err);
       fres(stdout);
     });

src/catSync.ts

@@ -6,6 +6,6 @@ import * as cp from 'child_process';
  * @returns full output (including all escape sequences)
  */
 function catSync(f: string): string {
-  return cp.execSync(`asciinema cat ${f}`, {encoding: 'utf8'});
+  return cp.execFileSync('asciinema', ['cat', f], {encoding: 'utf8'});
 }
 export default catSync;

src/rec.ts

@@ -23,7 +23,7 @@ import type {RecOptions, callbackFn} from './_types';
 function rec(f: string=null, o: RecOptions=null, fn: callbackFn=null): Promise<any> {
   var f = f||path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'asciinema-')), '0.cast');
   var p = new Promise((fres, frej) => {
-    cp.exec(recCmd(f, o), {encoding: 'utf8'}, (err) => {
+    cp.execFile('asciinema', recCmd(f, o), {encoding: 'utf8'}, (err) => {
       if(err) return frej(err);
       fres(f);
     });

src/recSync.ts

@@ -21,7 +21,7 @@ import type {RecOptions} from './_types';
  */
 function recSync(f: string, o: RecOptions=null): string {
   var f = f||path.join(fs.mkdtempSync(path.join(os.tmpdir(), 'asciinema-')), '0.cast');
-  cp.execSync(recCmd(f, o), {encoding: 'utf8'});
+  cp.execFileSync('asciinema', recCmd(f, o), {encoding: 'utf8'});
   return f;
 }
 export default recSync;

src/upload.ts

@@ -9,7 +9,7 @@ import type {callbackFn} from './_types';
  */
 function upload(f: string, fn: callbackFn=null): Promise<any> {
   var p = new Promise((fres, frej) => {
-    cp.exec(`asciinema upload ${f}`, {encoding: 'utf8'}, (err, stdout) => {
+    cp.execFile('asciinema', ['upload', f], {encoding: 'utf8'}, (err, stdout) => {
       if(err) return frej(err);
       fres(stdout.replace(/.*?(https?:\S+).*/s, '$1'));      
     });

src/uploadSync.ts

@@ -6,7 +6,7 @@ import * as cp from 'child_process';
  * @returns asciicast URL
  */
 function uploadSync(f: string): string {
-  var stdout = cp.execSync(`asciinema upload ${f}`, {encoding: 'utf8'});
+  var stdout = cp.execFileSync('asciinema', ['upload', f], {encoding: 'utf8'});
   return stdout.replace(/.*?(https?:\S+).*/s, '$1');
 }
 export default uploadSync;