Merge pull request #1030 from smith-kyle/oid-leak

Memory management: plugged leak in fastWalk
nodegit · May 11, 2016 · c889fea · c889fea
2 parents 7c2f7ef + 7ed0303
commit c889fea
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/generate/templates/manual/revwalk/fast_walk.cc b/generate/templates/manual/revwalk/fast_walk.cc
@@ -73,9 +73,11 @@ void GitRevwalk::FastWalkWorker::HandleOKCallback()
     unsigned int size = baton->out->size();
     Local<Array> result = Nan::New<Array>(size);
     for (unsigned int i = 0; i < size; i++) {
-      Nan::Set(result, Nan::New<Number>(i), GitOid::New(baton->out->at(i), false));
+      Nan::Set(result, Nan::New<Number>(i), GitOid::New(baton->out->at(i), true));
     }
 
+    delete baton->out;
+
     Local<v8::Value> argv[2] = {
       Nan::Null(),
       result