Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-API support for nodegit #1298

Open
digitalinfinity opened this issue Jun 6, 2017 · 17 comments
Open

N-API support for nodegit #1298

digitalinfinity opened this issue Jun 6, 2017 · 17 comments

Comments

@digitalinfinity
Copy link

Hello! The recently announced Node 8 has a new experimental feature called N-API which is aimed at reducing maintenance cost for node native addons.

Check out this blog for more details on its benefits.

nodegit is one of the top 30 native modules by download dependency count, and in order to help the Node.js community make the important transition to N-API, we are hoping you will be able to work with us in order to port nodegit to support N-API. Your support and feedback is important in making this effort a success.
I am part of the N-API working group and would like to talk to you about how you can get started with N-API and how we can help. I'm available to talk on the phone individually if you'd like. Alternatively, if you prefer, feel free to jump in our WG meeting, which happens every Thursday at 1.30 Eastern/10.30 Pacific US time, to discuss any issues.

Here’s a video of N-API in action
https://www.youtube.com/watch?v=nmXhJ88nZsk
@digitalinfinity digitalinfinity mentioned this issue Jun 6, 2017
Closed
@tbranyen
Copy link
Member

tbranyen commented Jun 8, 2017

Darn I missed the WG meeting today, I'll catch it next week!

@digitalinfinity
Copy link
Author

digitalinfinity commented Jun 8, 2017 via email

This was referenced Jun 9, 2017
Closed
Closed
@rcjsuen rcjsuen mentioned this issue Jun 19, 2017
Closed
@digitalinfinity
Copy link
Author

Hi @tbranyen - there is a WG meeting planned for tomorrow at 10:30 AM PDT (5:30 PM UTC)- the hangout link is still the same - we'd love to have you join in, the members of the WG would be happy to answer any questions you might have on N-API.

@tbranyen
Copy link
Member

@digitalinfinity I've been finding it hard to get time for this. Tomorrow I have either jury duty or I'm out sailing w/ my team (really hoping they don't call me in to court). I will do my best to try and get next Thursday available.

@johnhaley81 by any chance do you have time to attend tomorrow in my place?

@maxkorp
Copy link
Collaborator

maxkorp commented Jun 28, 2017

@tbranyen @johnhaley81 I canhop in if needed.

@digitalinfinity
Copy link
Author

all are welcome 😄 - @tbranyen @maxkorp @johnhaley81 we can also schedule a special one-off hangout with nodegit maintainers based on your availability to answer any questions you may have on N-API too, if that's more convenient

@maxkorp
Copy link
Collaborator

maxkorp commented Jun 28, 2017

I'll hop in the WG for sure 👍

@digitalinfinity
Copy link
Author

@maxkorp awesome! looking forward to meeting you- if you have any issues with joining the hangout, let me know here on this thread and we'll try and unblock you

@maxkorp
Copy link
Collaborator

maxkorp commented Jun 29, 2017

I got meetinged and wasn't able to make it 😦. I'll have some time this weekend to start taking a look at this more in depth though.

@digitalinfinity
Copy link
Author

No worries! Let us know if you have any questions, and if y'all want to schedule a separate call with WG members, that offer still stands 😄

@maxkorp
Copy link
Collaborator

maxkorp commented Jun 29, 2017

Awesome, thanks!

@johnhaley81
Copy link
Collaborator

Hey guys, sorry I've been pretty unresponsive as of late. When is the next meeting?

@johnhaley81
Copy link
Collaborator

If I just read the first message again...

Alternatively, if you prefer, feel free to jump in our WG meeting, which happens every Thursday at 1.30 Eastern/10.30 Pacific US time, to discuss any issues.

This is still the same? Same hangouts link?

@digitalinfinity
Copy link
Author

digitalinfinity commented Jul 3, 2017 via email

@johnhaley81
Copy link
Collaborator

A quick summary of the Hangouts:

During migration to N-API any issues can be opened at https://github.com/nodejs/abi-stable-node
The C++ Wrapper package can be found at: https://github.com/nodejs/node-addon-api
The documentation for N-API in node is at: https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html

Currently there is no support for Electron but it's in the early stages. There is also no support for node v6 but that is also a possibility after the API stabilizes. node-pre-gyp is also not supported yet but it's now noted that it's a big issue for NodeGit to fully migrate.

Before these are solved the N-API version will have to live on a different branch since these are blocking issues.

I'll try to start some preliminary work on this to see what the scope of the migration will be, what API's are missing and are needed by NodeGit and document the experience.

@rcjsuen rcjsuen mentioned this issue Jul 26, 2017
Closed
@a-teammate
Copy link

I'd like to add here, that with node.js 10 the N-API is no longer considered experimental :)
Changelog

How do you plan to do the transition? Is it something you want to achieve in one of the next milestones or how much priority does this have to you?

@Croydon Croydon mentioned this issue Jul 27, 2018
Closed
@implausible
Copy link
Member

We should probably get around to this sometime this year.

@Livven Livven mentioned this issue May 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@digitalinfinity @tbranyen @johnhaley81 @maxkorp @implausible @a-teammate