-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] use async/await syntax? #1867
Comments
…ra where possible See nodegit#1867
For some context |
Necessary for nodegit#1867. See https://www.npmjs.com/package/istanbul for reference on the istanbul to nyc transition. Since istanbul is outdated and doesn't support async/await syntax. The nyc CLI does not support the --expose-gc flag, so we additionally use the expose-gc package.
Necessary for nodegit#1867. See https://jshint.com/docs/options/#esnext for reference on the esnext option being deprecated. esversion 9 is the earliest one to support async/await.
I have completed a translation from Everything builds and passes the entire test suite. Throughout the process I also upgraded the test runner from istanbul to nyc. It turns out that istanbul has been deprecated, and nyc is the recommended solution now. See samuela@63c801c for more info. Using async/await syntax also required upgrading jshint, and updating the configuration to use the I'd be happy to contribute all these changes upstream if they are of interest to maintainers. Let me know! (cc @implausible @ianhattendorf others?) |
Could this be considered? |
Why is this being ignored? Is there some good reason to avoid migrating the project to the modern async/await syntax? |
As I dig through the source, I'm noticing that there's a lot of messy manual Promise chaining, eg. https://github.com/nodegit/nodegit/blob/master/generate/scripts/generateNativeCode.js#L121-L171. Is there a reason not to use async/await syntax? I'd be happy to submit some PRs if maintainers would be interested.
The text was updated successfully, but these errors were encountered: