Try re-enabling node >6.2 #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, this works for me locally now (I got the same break appveyor is showing before, but now i don't get that with my last change). Edit: User error. Def still broken >.< |
maxkorp
force-pushed
the
node-6.3
branch
2 times, most recently
from
8f483d3
to
33d17cb
Compare
|
Depends on #1125 Not comfortable calling this the correct long term fix (not sure if it links to the built in or our own when both are available) but better than not building at all. Thanks to @implausible for helping find this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.3 is working for me locally now, so trying this here.