Remove unnecessary assignment of Commit#repo #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @tbranyen, @johnhaley81, @maxkorp. |
|
It's been far more than a year, please close this if you do not want to merge it. |
|
Tests aren't passing and the CI is failing. We can't merge it like this. Please correct the issues or ask for help and we can get this merged if it's still needed. |
|
@tbranyen If I remember correctly, the failures were due to problems on your side, not on mine, and CI last ran two years ago on this. But sure, I will rebase and force-push to cause a new CI run. |
Repository#getCommit uses Commit.lookup and then manually assigns to Commit#repo even though Commit.lookup already does that.
tniessen
force-pushed
the
repository-remove-unnecessary-assignment
branch
from
112317f
to
c2b61a2
Compare
|
My patch seems to be working fine, so it must have been problems with your existing code or your CI setup. |
|
Looks good 👍, thanks for getting the PR into a mergeable state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository#getCommitusesCommit.lookupand then manually assigns toCommit#repoeven thoughCommit.lookupalready does that. There is no way forCommit.lookupto return aCommitwithout arepoproperty.