Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Commit#amendWithSignature #1617

Merged
merged 4 commits into from
Jan 30, 2019

Conversation

emmax86
Copy link
Collaborator

@emmax86 emmax86 commented Jan 29, 2019

Fixes two issues with the Commit#amendWithSignature method:

  1. Non-null arguments which override the values from the commit object were being ignored.
  2. An extra newline was being inserted into the commit message. This caused extraneous newlines to be appended to commit messages, esp. when the amend operation was repeated.

@emmax86
Copy link
Collaborator Author

emmax86 commented Jan 30, 2019

As a follow up, I would love to see if we could use the git_message_prettify function in libgit2 for formatting messages before passing them into the commit buffer. However, it does not seem to be exposed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants