Handle new gyp information for electron builds #1623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Electron is now at version >4, the iojs qualifier on the version number in the folder name for node headers stored in
~/.node-gyp
is no longer appended. This is because iojs and node merged at node v4. So that's the reason the <4 electron headers had iojs appended onto their header folder name. Now we need to support >4.I tried messing about a bit with the exported config.gypi that is provided in the electron headers, but it doesn't seem to be included from the start :(. In lieu of going back to some sort of pangyp again, I've just parsed the config.gypi with json5 and am hoping for the best. We'll probably be back here in a year or 2 going, why? Why?!