Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libgit2 to 1.5.0 #1929

Closed
wants to merge 7 commits into from
Closed

Conversation

zawata
Copy link
Contributor

@zawata zawata commented Aug 15, 2022

For changes made from 1.3.1 to 1.4.3 see #1913

Also included in this PR:

  • Enabled SHA256 Implementation
  • Bumped node-gyp to 9.1.0, done by accident but probably not a bad idea to keep in
  • Removed headers from libgit.gyp. Not sure why they were in there, they were just taking up space
  • I think that's it?

Note that this PR doesn't include SHA256 support, it just enables the hash implementation which is unused in this version but will be enabled in the next major version.
SHA256 is implemented with openssl instead of the builtin version as recommended here:
libgit2/libgit2#6144 (comment)

@zawata zawata mentioned this pull request Aug 15, 2022
apparently this is recommended by both ed and the upstream git project. In fact it's so recommended they're considering deprecating any alternatives.
updated to fix a merge issue and add another feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant