Don't free the given repo on error in getReferences and getRemotes #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zawata
force-pushed
the
fix/dontFreeRepoOnRefError
branch
from
64d4adb
to
112e142
Compare
zawata
force-pushed
the
fix/dontFreeRepoOnRefError
branch
from
112e142
to
3367d9d
Compare
we didn't create the repo so we can't be the ones to free it
spawning cmd files without shell: true wasn't really allowed before, but not it's expressly disallowed because of a recent vulnerability reported to node
zawata
force-pushed
the
fix/dontFreeRepoOnRefError
branch
from
674dd4c
to
c12c5a4
Compare
ianhattendorf
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that occurs on windows when trying to run
Repository.getReferences()on a repo with refs that exceed the path-length limit in libgit2 more than once.I don't know how else to trigger this issue so I can't really add a test for it.