Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include missing lib files in nodegit.js template #455

Merged
merged 2 commits into from Mar 3, 2015
Merged

Include missing lib files in nodegit.js template #455

merged 2 commits into from Mar 3, 2015

Conversation

orderedlist
Copy link
Collaborator

We should probably script these inclusions, so future additions don't get
missed.

@orderedlist
Some lib files were missing from nodegit.js template
7ed2e6a 
We should probably script these inclusions, so future additions don't get 
missed.
@orderedlist
Copy link
Collaborator Author

There were a few classes here (Reset for example) that worked in the tests because we were directly requiring the lib file, but not when using NodeGit.Reset.

@johnhaley81
Copy link
Collaborator

Eventually we'll need to do #456

@johnhaley81 johnhaley81 modified the milestone: 0.3.0 Mar 3, 2015
@tbranyen
Copy link
Member

tbranyen commented Mar 3, 2015

This now resolves #456 as well.

tbranyen added a commit that referenced this pull request Mar 3, 2015
@tbranyen
Merge pull request #455 from nodegit/ol-fix-including-lib
2542c04 
Include missing lib files in nodegit.js template
@tbranyen tbranyen merged commit 2542c04 into master Mar 3, 2015
@tbranyen tbranyen deleted the ol-fix-including-lib branch March 3, 2015 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orderedlist @johnhaley81 @tbranyen