Fix freeing a GitOid that was passed as a string
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure this fixes: #501 right? |
|
That should fix it. |
|
Ugh, timeouts are killing the tests... |
johnhaley81
added a commit
that referenced
this pull request
Apr 7, 2015
Fix freeing a `GitOid` that was passed as a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will allow a user to pass a string as a valid parameter for any parameter that is a
GitOid. In the function will will then convert that parameter to aGitOidand then free it after it's no longer in use. In a synchronous function we just didfree(&arg)which was causing an issue in Windows. Now we'll appropriately cast that to avoid *that will allow MSBUILD to free it without crashing.