Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Unused variables / logging X amount of lines and listing appname for log #285

Open
blakmatrix opened this Issue · 2 comments

2 participants

@blakmatrix

While running through the code for the comand logs i noticed that the variables amount and showApp are not utilized but referenced in other calls

@jesusabdullah also has more info from a ticket supposedly

@blakmatrix blakmatrix referenced this issue from a commit
@blakmatrix blakmatrix [minor] #285 added todo 0c73d7a
@blakmatrix blakmatrix referenced this issue from a commit
@blakmatrix blakmatrix [minor] #285 added todo 49c0117
@jfhbrook jfhbrook closed this
@blakmatrix

@jesusabdullah this hasn't been fixed. all i did was add a comment here to keep the attention on the issue I found. the function still doesnt utilize variables(the variables amount and showApp ) passed to it https://github.com/nodejitsu/jitsu/blob/master/lib/jitsu/commands/logs.js#L169-204

@blakmatrix blakmatrix reopened this
@jfhbrook

@blakmatrix Sorry, I guess I jumped the gun.

Is this something you can investigate? In theory we should be able to pass those vars to the API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.