Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables / logging X amount of lines and listing appname for log #285

Open
blakmatrix opened this issue Jul 21, 2012 · 2 comments
Open

Comments

@blakmatrix
Copy link
Contributor

While running through the code for the comand logs i noticed that the variables amount and showApp are not utilized but referenced in other calls

@jesusabdullah also has more info from a ticket supposedly

blakmatrix added a commit that referenced this issue Jul 21, 2012
blakmatrix added a commit that referenced this issue Sep 18, 2012
@blakmatrix
Copy link
Contributor Author

@jesusabdullah this hasn't been fixed. all i did was add a comment here to keep the attention on the issue I found. the function still doesnt utilize variables(the variables amount and showApp ) passed to it https://github.com/nodejitsu/jitsu/blob/master/lib/jitsu/commands/logs.js#L169-204

@blakmatrix blakmatrix reopened this Sep 25, 2012
@jfhbrook
Copy link
Contributor

@blakmatrix Sorry, I guess I jumped the gun.

Is this something you can investigate? In theory we should be able to pass those vars to the API call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants