Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to post-login-failure password resets #74

Merged
merged 1 commit into from Aug 15, 2011
Merged

Fixes to post-login-failure password resets #74

merged 1 commit into from Aug 15, 2011

Conversation

AvianFlu
Copy link
Contributor

This patch is meant to address two things.

First, when the reset prompt properties were moved to properties.js, the property.name changed from reset to request password reset - this was throwing off the match, and preventing the reset emails from ever getting sent.

Second, I was returning an error after the reset because of the way Jitsu's call stack appears to work. If one calls callback with no arguments, the command that Jitsu was attempting to run before asking for credentials is counted as having succeeded, which can lead to some genuinely strange UI messages. This is the output if the callback is called without arguments:

  info:   Request password reset for: aviantestertwo
  info:   Check your email for instructions on resetting your password.
  info:   Successfully configured user aviantestertwo
  info:   Executing command list
  error:  Unable to Authenticate as aviantestertwo
  error:  Nodejitsu Error (403): Not Authorized
  info:   Nodejitsu not ok

If an error is returned, on the other hand:

  info:   Request password reset for: aviantestertwo
  info:   Check your email for instructions on resetting your password.
  error:  Error running command list
  info:   Nodejitsu not ok

@AvianFlu
Copy link
Contributor Author

I have confirmed that this issue is still present with HEAD as of five minutes ago; I'm going to merge this.

AvianFlu added a commit that referenced this pull request Aug 15, 2011
Fixes to post-login-failure password resets
@AvianFlu AvianFlu merged commit 5a36744 into nodejitsu:master Aug 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant