Fixes to post-login-failure password resets #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is meant to address two things.
First, when the
reset
prompt properties were moved toproperties.js
, theproperty.name
changed fromreset
torequest password reset
- this was throwing off the match, and preventing the reset emails from ever getting sent.Second, I was returning an error after the reset because of the way
Jitsu
's call stack appears to work. If one callscallback
with no arguments, the command thatJitsu
was attempting to run before asking for credentials is counted as having succeeded, which can lead to some genuinely strange UI messages. This is the output if the callback is called without arguments:If an error is returned, on the other hand: