Add option for attaching outgoing headers, extraHeaders. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also required adjusting web-incoming to pass the options object to the web-outgoing passes. One thing I noticed is that web-outgoing doesn't appear to be exposed to anyone that wants mutate it externally. I think extensions of this nature would be better done via some well-defined API that allows me to mutate the passes on the proxy object. But, as it stands that doesn't exist and is too much for me to just guess at what would be acceptable and try to fix.
This was referenced Feb 11, 2014
|
Why aren't web-outgoing passes exposed the way incoming passes are exposed, for before and after hooks? |
|
@cheddar could you rebase the PR and rename to outgoingHeaders? This seems reasonable, sorry it took so long |
|
Also as a note, headers can be modified in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also required adjusting web-incoming to pass the options object to the web-outgoing passes. One thing I noticed is that web-outgoing doesn't appear to be exposed to anyone that wants mutate it externally.
I think extensions of this nature would be better done via some well-defined API that allows me to mutate the passes on the proxy object. But, as it stands that doesn't exist and is too much for me to just guess at what would be acceptable and try to fix.