Amazon S3 is broken

[indutny]

After this d96f7b1.

[indutny]

More info: signature fails because options.path is always undefined.

[kenperkins]

This is a good bug. Comparing the working branch (0.6.15) against master, I notice that the URL that the client actually creates a PUT against:

https://kptest2.s3.amazonaws.com/Vagrantfile

Is actually different than the URL that's used in signing:

  'PUT',
  '\n',
  '',
  '\n',
  'application/octet-stream',
  '\n',
  'Mon, 06 May 2013 16:48:32 GMT',
  '\n',
  '/kptest2/Vagrantfile'

I'll research into why amazon does this, but for now, I'll need to pass around the signingUrl for amazon.

[kenperkins]

This branch fixes the change (as a quick validation) but I'm not convinced I want this approach (where you pollute the official request options)

https://github.com/rackspace/pkgcloud/compare/awsFix

I'm going to think about a refactor for the "before" options to use a more first class object for passing around the input options and generating the real request options.

[cronopio]

@indutny a pull request to fix this was merged at master, can you test please and confirm that we can close this?

[indutny]

Doesn't seem to be working for me, though, it got a bit better now .createContainer() works, but .upload() is still failing!

[kenperkins]

Can you provide some sample code and details (node version, etc)? I have upload and createContainer both working for Amazon.

[indutny]

You can try it there: https://github.com/indutny/glacebox

[kenperkins]

Are you able to narrow it down? I don't really have time to look into your project to find out what's not working.

I can validate that a naked pkgcloud (v0.7.1) upload works:

var pkgcloud = require('pkgcloud');

var client = pkgcloud.providers.amazon.storage.createClient({
    keyId: 'redacted',
    key: 'redacted'
});

client.upload({
    container: 'kptest2',
    remote: 'GoogleVoiceAndVideoSetup.dmg',
    local: '/Users/me/Downloads/GoogleVoiceAndVideoSetup.dmg'
}, function(err, result) {
    console.dir(err);
    console.dir(result);
});

[kenperkins]

Fixed by #137