Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imminent issue for chilean users (tzdata2022b) #773

Closed
Manizuca opened this issue Aug 16, 2022 · 4 comments
Closed

Imminent issue for chilean users (tzdata2022b) #773

Manizuca opened this issue Aug 16, 2022 · 4 comments

Comments

@Manizuca
Copy link

The Chilean Government decided to delay the DST start from September 4 to September 11, in order to "avoid problems in election day" (we do held a plebiscite on September 4th).

Because of that, tzdata2022b was released (and now 2022c, that fixes a build-time issue). This update is critical for users that depend on having the correct time at the moment.

As I see with #576, the last couple of times this have happened, it was handled with relative quick, getting the updated the data from the icu-data repo (there is even a PR to do it automatically at nodejs/node#43988). As of now, icu-data has an open PR to update this at unicode-org/icu-data#28, and right now the data can be copied from the PR, but it should be accepted soon anyway.

Sadly, I see that the last LTS update was released just today (16.17.0). As i think this could be a critical issue, would it be possible to do a point-release in the following weeks to handle this, so it can be picked by downstream-distributions (AWS Lambda in my case)

Thanks.

@ljoui2
Copy link

ljoui2 commented Aug 17, 2022

I'm looking forward for this!!!!

albertyw added a commit to albertyw/node-1 that referenced this issue Aug 22, 2022
mhdawson pushed a commit to nodejs/node that referenced this issue Aug 26, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: #44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlau
Copy link
Member

A workaround for existing versions of Node.js: You can set ICU4C's ICU_TIMEZONE_FILES_DIR environment variable to point to a directory containing the updated .res files. Create a local directory and download into them the *.res files from https://github.com/unicode-org/icu-data/ matching the tzdata version and endianness and set ICU_TIMEZONE_FILES_DIR to point to that directory.

e.g.

$ ls /tmp/rlau/tz
metaZones.res  timezoneTypes.res  windowsZones.res  zoneinfo64.res
$ nvm run 16 -p "new Intl.DateTimeFormat('en-US', { hour12: false, timeZone: 'America/Santiago', year: 'numeric', month: '2-digit', day: '2-digit', hour: '2-digit', minute: '2-digit', second: '2-digit', timeZoneName: 'short' }).format(new Date('2022-09-05T00:00:00Z'))"
Running node v16.17.0 (npm v8.15.0)
09/04/2022, 21:00:00 GMT-3
$ ICU_TIMEZONE_FILES_DIR=/tmp/rlau/tz nvm run 16 -p "new Intl.DateTimeFormat('en-US', { hour12: false, timeZone: 'America/Santiago', year: 'numeric', month: '2-digit', day: '2-digit', hour: '2-digit', minute: '2-digit', second: '2-digit', timeZoneName: 'short' }).format(new Date('2022-09-05T00:00:00Z'))"
Running node v16.17.0 (npm v8.15.0)
09/04/2022, 20:00:00 GMT-4
$

Refs: https://unicode-org.github.io/icu/userguide/datetime/timezone/#icu4c-tz-update-with-drop-in-res-files-icu-54-and-newer

RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 5, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: #44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: nodejs#44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit to nodejs/node that referenced this issue Sep 16, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: #44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 10, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: #44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 11, 2022
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: #44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Oct 24, 2022
PR-URL: #45094
Refs: nodejs/Release#773
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: nodejs/node#44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29

PR-URL: nodejs/node#44283
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@ruyadorno
Copy link
Member

@richardlau I believe we can close this issue now?

@richardlau
Copy link
Member

I think we still haven't updated 16.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants