Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Async Hooks to section that needs champions #523

Merged
merged 3 commits into from
Apr 23, 2018
Merged

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Apr 18, 2018

As discussed in TSC Meeting, #520, move this to the section that needs champions.

@@ -51,4 +50,4 @@ and have the support needed.
[rvagg]: https://github.com/rvagg
[trott]: https://github.com/trott
[trevnorris]: https://github.com/trevnorris
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the line that would be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't see that!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrobots
Copy link
Contributor

I could help 'champion' async hooks. I can do so in a follow-on PR, or feel free to nominate me in this one :).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and @ofrobots thanks for volunteering.

@fhinkel fhinkel merged commit 7435edc into master Apr 23, 2018
@sam-github sam-github deleted the fhinkel-patch-4 branch December 5, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants