Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about own properties #33

Closed
wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Dec 12, 2016

Affected core subsystem(s)

JS VM Api

Description of change

Not V8 related, but do we need methods for own properties as well? Also, do we need a method that returns the property without invoking getters and interceptors (similar to v8::GetRealNamedProperty)?

@fhinkel fhinkel mentioned this pull request Dec 12, 2016
2 tasks
@bnoordhuis
Copy link
Member

bnoordhuis commented Dec 12, 2016

Engine support may be a bit sketchy. JavaScriptCore to the best of my knowledge doesn't support anything like it and some quick grepping suggests ChakraCore doesn't either.

EDIT: Doesn't mean adding a TODO comment is a bad idea. You have my LGTM if you want it but can you drop the whitespace change?

@mhdawson
Copy link
Member

Opening an issue for discussion as an alternative to adding the TODO comment is also an option.

@ianwjhalliday
Copy link

Unless performance critical, this sort of thing is usually accomplished by calling the JavaScript built-in. I.e. Object#hasOwnProperty in this case.

@aruneshchandra
Copy link
Contributor

Added issue #67 to track this. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants