Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install github dco app for use in ci-config-travis and ci-config-github-actions repos #492

Closed
mhdawson opened this issue Apr 14, 2020 · 7 comments

Comments

@mhdawson
Copy link
Member

For the new ci-config repos requested by the Package-maintenance team I'd like to enable the DCO github app https://github.com/apps/dco to enforce sign offs for the commits.

@mcollina
Copy link
Member

sgtm

@mhdawson
Copy link
Member Author

Discussed in TSC meeting 16 April 2020 and agreed could proceed if no objections in 72 hours: https://github.com/nodejs/TSC/blob/master/meetings/2020-04-16.md#nodejsadmin

@mhdawson
Copy link
Member Author

It requires these permissions:

Read access to code
Read access to members, metadata, and pull requests
Read and write access to checks

Will install for only the 2 specified repositories.

@joesepi
Copy link
Member

joesepi commented Apr 23, 2020

SGTM

@bnb
Copy link
Contributor

bnb commented Apr 23, 2020

+1, happy to enable projects to leverage apps they need.

@BethGriggs
Copy link
Member

+1

@mhdawson
Copy link
Member Author

Installed for the 2 specific repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants